Skip to content

cache charset bump #8691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 19, 2024
Merged

cache charset bump #8691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3fe752b
[no-release-notes] bump for cache charset id
max-hoffman Dec 18, 2024
98766e8
add sysbench tests
max-hoffman Dec 18, 2024
512dca6
fix build
max-hoffman Dec 19, 2024
0e694c8
[ga-format-pr] Run go/utils/repofmt/format_repo.sh and go/Godeps/upda…
max-hoffman Dec 19, 2024
bf9f80c
bump
max-hoffman Dec 19, 2024
932cf4b
Merge branch 'max/cache-charset-bump' of github.com:dolthub/dolt into…
max-hoffman Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ require (
github.com/cespare/xxhash/v2 v2.2.0
github.com/creasty/defaults v1.6.0
github.com/dolthub/flatbuffers/v23 v23.3.3-dh.2
github.com/dolthub/go-mysql-server v0.18.2-0.20241217205639-85adcd5e580f
github.com/dolthub/go-mysql-server v0.18.2-0.20241219174926-e44b780a5716
github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63
github.com/dolthub/swiss v0.1.0
github.com/goccy/go-json v0.10.2
Expand Down
4 changes: 2 additions & 2 deletions go/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,8 @@ github.com/dolthub/fslock v0.0.3 h1:iLMpUIvJKMKm92+N1fmHVdxJP5NdyDK5bK7z7Ba2s2U=
github.com/dolthub/fslock v0.0.3/go.mod h1:QWql+P17oAAMLnL4HGB5tiovtDuAjdDTPbuqx7bYfa0=
github.com/dolthub/go-icu-regex v0.0.0-20241215010122-db690dd53c90 h1:Sni8jrP0sy/w9ZYXoff4g/ixe+7bFCZlfCqXKJSU+zM=
github.com/dolthub/go-icu-regex v0.0.0-20241215010122-db690dd53c90/go.mod h1:ylU4XjUpsMcvl/BKeRRMXSH7e7WBrPXdSLvnRJYrxEA=
github.com/dolthub/go-mysql-server v0.18.2-0.20241217205639-85adcd5e580f h1:TTUk8P8Rt4YUrQ9A6yp91v5/kIlvWl30Mt3inK+V1Z4=
github.com/dolthub/go-mysql-server v0.18.2-0.20241217205639-85adcd5e580f/go.mod h1:elfIatfq2fkU5lqTBrTcpL0RcHZOgYPE8EzBD7yQFiY=
github.com/dolthub/go-mysql-server v0.18.2-0.20241219174926-e44b780a5716 h1:NsV88yNOo0hBkEpjkQxQAVM05owX7nQ+KCP6D2K0T0M=
github.com/dolthub/go-mysql-server v0.18.2-0.20241219174926-e44b780a5716/go.mod h1:elfIatfq2fkU5lqTBrTcpL0RcHZOgYPE8EzBD7yQFiY=
github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63 h1:OAsXLAPL4du6tfbBgK0xXHZkOlos63RdKYS3Sgw/dfI=
github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63/go.mod h1:lV7lUeuDhH5thVGDCKXbatwKy2KW80L4rMT46n+Y2/Q=
github.com/dolthub/ishell v0.0.0-20240701202509-2b217167d718 h1:lT7hE5k+0nkBdj/1UOSFwjWpNxf+LCApbRHgnCA17XE=
Expand Down
22 changes: 20 additions & 2 deletions go/performance/microsysbench/sysbench_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
"strings"
"testing"

"github.com/dolthub/go-mysql-server/server"
"github.com/dolthub/go-mysql-server/sql"
"github.com/stretchr/testify/require"

Expand Down Expand Up @@ -60,6 +61,18 @@ func BenchmarkOltpPointSelect(b *testing.B) {
})
}

func BenchmarkTableScan(b *testing.B) {
benchmarkSysbenchQuery(b, func(int) string {
return "SELECT * FROM sbtest1"
})
}

func BenchmarkOltpIndexScan(b *testing.B) {
benchmarkSysbenchQuery(b, func(int) string {
return "SELECT * FROM sbtest1 WHERE k > 0"
})
}

func BenchmarkOltpJoinScan(b *testing.B) {
benchmarkSysbenchQuery(b, func(int) string {
return `select a.id, a.k
Expand Down Expand Up @@ -109,12 +122,17 @@ func BenchmarkSelectRandomRanges(b *testing.B) {
func benchmarkSysbenchQuery(b *testing.B, getQuery func(int) string) {
ctx, eng := setupBenchmark(b, dEnv)
for i := 0; i < b.N; i++ {
_, iter, _, err := eng.Query(ctx, getQuery(i))
schema, iter, _, err := eng.Query(ctx, getQuery(i))
require.NoError(b, err)
i := 0
for {
if _, err = iter.Next(ctx); err != nil {
i++
row, err := iter.Next(ctx)
if err != nil {
break
}
outputRow, err := server.RowToSQL(ctx, schema, row, nil)
_ = outputRow
}
require.Error(b, io.EOF)
err = iter.Close(ctx)
Expand Down