Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SchemaName to DatabaseSchema interface #8062

Merged
merged 11 commits into from
Jun 25, 2024
Merged

add SchemaName to DatabaseSchema interface #8062

merged 11 commits into from
Jun 25, 2024

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp mentioned this pull request Jun 24, 2024
Merged
@coffeegoddd
Copy link
Contributor

@jennifersp DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c67c32d ok 5937457
version total_tests
c67c32d 5937457
correctness_percentage
100.0

@jennifersp jennifersp requested a review from zachmu June 24, 2024 21:44
@coffeegoddd
Copy link
Contributor

@jennifersp DOLT

comparing_percentages
100.000000 to 100.000000
version result total
30fa4bf ok 5937457
version total_tests
30fa4bf 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@jennifersp DOLT

comparing_percentages
100.000000 to 100.000000
version result total
7477d76 ok 5937457
version total_tests
7477d76 5937457
correctness_percentage
100.0

@jennifersp jennifersp changed the title the method AllSchemas() return map add SchemaName to SchemaDatabase interface Jun 25, 2024
@jennifersp jennifersp changed the title add SchemaName to SchemaDatabase interface add SchemaName to DatabaseSchema interface Jun 25, 2024
@github-actions GitHub Actions
Copy link

Additional work is required for integration with DoltgreSQL.

zachmu
zachmu approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

Additional work is required for integration with DoltgreSQL.

@coffeegoddd
Copy link
Contributor

@jennifersp DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e74015c ok 5937457
version total_tests
e74015c 5937457
correctness_percentage
100.0

@github-actions GitHub Actions
Copy link

Additional work is required for integration with DoltgreSQL.

@github-actions GitHub Actions
Copy link

Additional work is required for integration with DoltgreSQL.

@coffeegoddd
Copy link
Contributor

@jennifersp DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c2ca1a1 ok 5937457
version total_tests
c2ca1a1 5937457
correctness_percentage
100.0

@jennifersp jennifersp closed this Jun 25, 2024
@jennifersp jennifersp reopened this Jun 25, 2024
@github-actions GitHub Actions
Copy link

Additional work is required for integration with DoltgreSQL.

@jennifersp jennifersp merged commit 4c704c3 into main Jun 25, 2024
39 of 41 checks passed
@jennifersp jennifersp deleted the jennifer/all-schemas branch June 25, 2024 22:35
@coffeegoddd
Copy link
Contributor

@jennifersp DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c2ca1a1 ok 5937457
version total_tests
c2ca1a1 5937457
correctness_percentage
100.0

@BrewTestBot BrewTestBot mentioned this pull request Jun 26, 2024
Merged
@fulghum fulghum mentioned this pull request Jun 26, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jennifersp @coffeegoddd @zachmu @fulghum