Skip to content

Conversation

@nustiueudinastea
Copy link
Contributor

This PR converts all instances of the RepoState.Branches to a concurrent map (implementation found in utils). Avoids issues when the branches field is accessed concurrently from different routines.

This PR is waiting for #7019 to be merged first to integrate those changes.

@timsehn
Copy link
Contributor

timsehn commented Nov 20, 2023

#7019 is merged :-)

@nustiueudinastea nustiueudinastea marked this pull request as ready for review November 21, 2023 11:31
@nustiueudinastea
Copy link
Contributor Author

@timsehn @zachmu this PR is ready for review

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution

@zachmu zachmu merged commit f8e2371 into dolthub:main Nov 21, 2023
@nustiueudinastea nustiueudinastea deleted the concurrent-branches-map branch November 21, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants