implement spatial indexes #5164
Conversation
…/dolt into james/spatial-index-test
jycor
changed the title
| Tags []uint64 `noms:"tags" json:"tags"` | ||
| Comment string `noms:"comment" json:"comment"` | ||
| Unique bool `noms:"unique" json:"unique"` | ||
| Spatial bool `noms:"spatial,omitempty" json:"spatial,omitempty"` |
There was a problem hiding this comment.
you should revert these changes, we don't support spatial indexes in the old format. you should also add some tests to confirm this
| return &multipointType{sqlType.(gmstypes.MultiPointType)}, nil | ||
| case gmstypes.MultiLineStringType{}.String(): | ||
| return &multilinestringType{}, nil | ||
| return &multilinestringType{sqlType.(gmstypes.MultiLineStringType)}, nil | ||
| case gmstypes.MultiPolygonType{}.String(): | ||
| return &multipolygonType{}, nil | ||
| return &multipolygonType{sqlType.(gmstypes.MultiPolygonType)}, nil | ||
| case gmstypes.GeomCollType{}.String(): | ||
| return &geomcollType{}, nil | ||
| return &geomcollType{sqlType.(gmstypes.GeomCollType)}, nil | ||
| case gmstypes.GeometryType{}.String(): | ||
| return &geometryType{sqlGeometryType: sqlType.(gmstypes.GeometryType)}, nil |
There was a problem hiding this comment.
what is this change for?
There was a problem hiding this comment.
This is something I should've implemented when I was originally implementing MultiPoint, MultiLineString, MultiPolygon, and GeometryCollection. When defining columns over these types, we're able to specify a default SRID, and sqlType is what remembers the columns user defined SRID.
Example: create table t (p point srid 0)
Having a SRID defined is required for Spatial Indexes to work.
| // TODO: the descriptors in the primary key are different | ||
| // than the ones in the secondary key; this test assumes | ||
| // they're the same | ||
| if len(def.PrefixLengths()) > 0 || def.IsSpatial() { |
There was a problem hiding this comment.
implement the logic to validate both of these speacial case indexes, rather than just skipping them. otherwise you're eroding the value of this validation
2 participants
Changes:
DOLT_ENABLE_SPATIAL_INDEXCompanion PR: dolthub/go-mysql-server#1558
Note: prepared test that I changed here had a column anmed
commit, which got confused withto_commitin the diff #5188TODOs