Skip to content

use range instead of point lookups for non-unique indexes #4873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 29, 2022
Merged

use range instead of point lookups for non-unique indexes #4873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f31f236
use range lookups for non-unique indexes
Nov 28, 2022
e599607
bump
Nov 28, 2022
626a111
merge with main
Nov 28, 2022
b38667b
manualbump
Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ require (
github.com/cenkalti/backoff/v4 v4.1.3
github.com/cespare/xxhash v1.1.0
github.com/creasty/defaults v1.6.0
github.com/dolthub/go-mysql-server v0.14.1-0.20221128214028-c667104210d5
github.com/dolthub/go-mysql-server v0.14.1-0.20221128225113-62e11befcf1b
github.com/google/flatbuffers v2.0.6+incompatible
github.com/kch42/buzhash v0.0.0-20160816060738-9bdec3dec7c6
github.com/mitchellh/go-ps v1.0.0
Expand Down
4 changes: 2 additions & 2 deletions go/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,8 @@ github.com/dolthub/flatbuffers v1.13.0-dh.1 h1:OWJdaPep22N52O/0xsUevxJ6Qfw1M2txC
github.com/dolthub/flatbuffers v1.13.0-dh.1/go.mod h1:CorYGaDmXjHz1Z7i50PYXG1Ricn31GcA2wNOTFIQAKE=
github.com/dolthub/fslock v0.0.3 h1:iLMpUIvJKMKm92+N1fmHVdxJP5NdyDK5bK7z7Ba2s2U=
github.com/dolthub/fslock v0.0.3/go.mod h1:QWql+P17oAAMLnL4HGB5tiovtDuAjdDTPbuqx7bYfa0=
github.com/dolthub/go-mysql-server v0.14.1-0.20221128214028-c667104210d5 h1:X8Po39PjrEsu+mpjbNbc2BjH7JKCFl6J6WaBTtzTV6A=
github.com/dolthub/go-mysql-server v0.14.1-0.20221128214028-c667104210d5/go.mod h1:C6JXtRWMLzvwPU8EN7fIwaJJh3mD/pU6XFs7ROWe5PE=
github.com/dolthub/go-mysql-server v0.14.1-0.20221128225113-62e11befcf1b h1:YhJbZo4PGQiSlx89f6+Zkdz54jSUC5+pL0vferMEmwI=
github.com/dolthub/go-mysql-server v0.14.1-0.20221128225113-62e11befcf1b/go.mod h1:C6JXtRWMLzvwPU8EN7fIwaJJh3mD/pU6XFs7ROWe5PE=
github.com/dolthub/ishell v0.0.0-20220112232610-14e753f0f371 h1:oyPHJlzumKta1vnOQqUnfdz+pk3EmnHS3Nd0cCT0I2g=
github.com/dolthub/ishell v0.0.0-20220112232610-14e753f0f371/go.mod h1:dhGBqcCEfK5kuFmeO5+WOx3hqc1k3M29c1oS/R7N4ms=
github.com/dolthub/jsonpath v0.0.0-20210609232853-d49537a30474 h1:xTrR+l5l+1Lfq0NvhiEsctylXinUMFhhsqaEcl414p8=
Expand Down
5 changes: 5 additions & 0 deletions go/libraries/doltcore/sqle/index/dolt_index.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,6 +862,11 @@ func (di *doltIndex) prollyRangesFromSqlRanges(ctx context.Context, ns tree.Node

order := di.keyBld.Desc.Comparator()
for i, field := range fields {
// lookups on non-unique indexes can't be point lookups
if !di.unique {
fields[i].Exact = false
continue
}
if !field.Hi.Binding || !field.Lo.Binding {
fields[i].Exact = false
continue
Expand Down