Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two small refactoring tools inline method bug fixes #1223

Merged
merged 3 commits into from
Dec 17, 2023
Merged

Two small refactoring tools inline method bug fixes #1223

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
972ec20
Yet another bug in 039d500738abdbc07cc5b64493cc43a7eb9dfb46
blairmcg Jul 24, 2023
a88a531
Inline expression prompt show changes choice does carry to next prompt
blairmcg Aug 10, 2023
021fd21
Temporary fix for difficult to diagnose package load errors on boot
blairmcg Oct 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Temporary fix for difficult to diagnose package load errors on boot 
DolphinProduct translates missing package prerequisite paths losing the
package name, which makes diagnosis difficult. The mechanism for reporting
missing pre-reqs needs a deeper change to avoid PackageManager>>install:
suppressing package loading errors and appearing to succeed, but loading
no packages.
  • Loading branch information
@blairmcg
blairmcg committed Dec 17, 2023
commit 021fd21396141792b90dccffd634cf5a1da5482e
2 changes: 1 addition & 1 deletion Core/Object Arts/Dolphin/Installation Manager/Tools.DolphinProduct.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ basicLoad
packageManager packageNamed: name
ifNone:
[[packageManager install: each] on: packageManager prerequisiteNotFoundSignal
do: [:ex | ex resume: (File splitPathFrom: each)]]].
do: [:ex | ex resume: ex messageText]]].
Smalltalk developmentSystem beNotChanged!

beCurrent
Expand Down