Improve clarity of message box shown for unhandled warning #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an identifier auto-completion list is opened in a workspace and a MessageBox instance is assigned to one of the variables in scope that are placed in the auto-completion list, a nil DNU will result because the #icon method of MessageBox usually returns nil. This doesn't meet the general expectation that any Object can be asked for an icon (usually returning the class icon).
…sages flags variable is not initialized if the Structure doesn't define any new fields.
Use the new message box to include explanatory text, and change the confusing Abort/Retry/Ignore button labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new message box to include explanatory text, and change the confusing Abort/Retry/Ignore button labels.