Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dolphin 7.1.24: Wrong seconds calculation in Duration class>>hours:minutes: #1183

Closed
bernhardkohlhaas opened this issue Feb 21, 2023 · 0 comments
Closed

Dolphin 7.1.24: Wrong seconds calculation in Duration class>>hours:minutes: #1183

bernhardkohlhaas opened this issue Feb 21, 2023 · 0 comments
Labels
bug

Comments

@bernhardkohlhaas
Copy link
Contributor

bernhardkohlhaas commented Feb 21, 2023 •
edited
Loading

Describe the bug
The result of the evaluation of Duration hours: 1 minutes: 0 is a duration of 2.5 days, instead of 60 minutes.

The bug is in method Duration class>hours:minutes:
Instead of ^self seconds: (hoursNumber * 3600) + minutesNumber * 60,

it should be ^self seconds: (hoursNumber * 3600) + (minutesNumber * 60) that is with parentheses around minutesNumber * 60 (or alternatively something similar to the code in Duration class>>hours:minutes:seconds:)

To Reproduce
Evaluate and display the result of Duration hours: 1 minutes: 0.

Please complete the following information):

  • OS: Windows 10 Pro 21H2
  • Dolphin version 7.1.24 (bug also still present in Dolphin 8).
blairmcg added a commit that referenced this issue Mar 24, 2023
@blairmcg
Fix #1183: Wrong seconds calc in Duration class>>hours:minutes:
f9b8564 
Missing parenthesis.
blairmcg added a commit that referenced this issue Mar 24, 2023
@blairmcg
Fix #1183: Wrong seconds calc in Duration class>>hours:minutes:
d840694 
Missing parenthesis.
blairmcg added a commit that referenced this issue Mar 25, 2023
@blairmcg
Fix #1183: Wrong seconds calc in Duration class>>hours:minutes:
3130217 
Merge from D8 also brings across #testhumanReadablePrintString
blairmcg added a commit that referenced this issue Mar 25, 2023
@blairmcg
Fix #1183: Wrong seconds calc in Duration class>>hours:minutes: (#1185)
4f9d3c6 
Merge from D8 also brings across #testhumanReadablePrintString
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bernhardkohlhaas