Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt/AdvancedPane: UI improvements. #12115

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

AdmiralCurtiss
Copy link
Contributor

  • Use fancy tooltips for MMU, Pause on Panic, and Write-back Cache.
  • Bold the three above mentioned settings when they are overridden by GameINI.
  • The RAM Override and RTC Override checkboxes now correctly check themselves when overridden by GameINI.

Before:
advanced-before

After:
advanced-after

@mbc07
Copy link
Member

mbc07 commented Aug 17, 2023

(out of scope for this PR, just food for thought)

Looking at this more, we could probably move the text descriptions of Emulated CPU Clock, Emulated Memory and Custom RTC options to the custom tooltips at some point. Would solve the longstanding issue of the settings window being too tall without actually moving options from this tab to somewhere else (which wasn't well received on previous attempts)...

Copy link
Contributor

@MayImilae MayImilae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JosJuice
Copy link
Member

Looking at this more, we could probably move the text descriptions of Emulated CPU Clock, Emulated Memory and Custom RTC options to the custom tooltips at some point. Would solve the longstanding issue of the settings window being too tall without actually moving options from this tab to somewhere else (which wasn't well received on previous attempts)...

Users already ignore the warning for Emulated CPU Clock and Emulated Memory too much as it is. Turning the warnings into tooltips would likely make it worse.

@AdmiralCurtiss AdmiralCurtiss merged commit ecf5870 into dolphin-emu:master Aug 17, 2023
@AdmiralCurtiss AdmiralCurtiss deleted the advanced-config branch August 17, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants