Fix the warnings with Constant and subfunctions. #133

Ig-dolci · 2024-02-13T12:10:45Z

This PR updates the firedrake tests with the correct definitions.

Move from Connstant(any_value, domain=mesh) to Functtion(R).assign(any_value), where R = FunctionSpace(mesh, "R", 0).
Move from f.split to f.sub.

tests/firedrake_adjoint/test_disk_checkpointing.py

tests/firedrake_adjoint/test_projection.py

tests/firedrake_adjoint/test_reduced_functional.py

tests/firedrake_adjoint/test_solving.py

tests/firedrake_adjoint/test_split.py

Co-authored-by: David A. Ham <david.ham@imperial.ac.uk>

tests/firedrake_adjoint/test_reduced_functional.py

Fix the warnings with Constant and subfunctions.

bed8947

dham requested changes Feb 14, 2024

View reviewed changes

Ig-dolci and others added 5 commits February 15, 2024 10:35

Update tests/firedrake_adjoint/test_disk_checkpointing.py

150b63b

Co-authored-by: David A. Ham <david.ham@imperial.ac.uk>

Update tests/firedrake_adjoint/test_split.py

827e83d

Co-authored-by: David A. Ham <david.ham@imperial.ac.uk>

Suitable Real function usage and remove new variables.

f0f1bbc

Suitable real function usage.

da2f85f

remove new variable

2169d5e

Ig-dolci commented Feb 15, 2024

View reviewed changes

tests/firedrake_adjoint/test_reduced_functional.py Show resolved Hide resolved

Ig-dolci requested a review from dham February 15, 2024 11:33

Ig-dolci added 2 commits February 15, 2024 11:35

Update test_hessian.py

79942ed

Update test_hessian.py

5763641

dham approved these changes Feb 16, 2024

View reviewed changes

dham merged commit df36259 into master Feb 16, 2024
2 checks passed

dham deleted the dolci/fix_warnings branch February 16, 2024 16:22

Provide feedback