Add the plugin to the safe.directory list #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows dokku to trigger plugin:update as root while keeping plugins owned by the Dokku user. See https://github.blog/2022-04-12-git-security-vulnerability-announced/ for more details on this change (which was backported in to Git 2.25.1 for Ubuntu). Closes dokku/dokku#5186
josegonzalez
added a commit
that referenced
this pull request
May 19, 2022
### Fixed - @josegonzalez Ignore plugins that do not have a .git directory when performing updates #90 - @josegonzalez Add the plugin to the safe.directory list #92 ### Changed - @josegonzalez Do not require PLUGIN_PATH to fetch version #91 - @josegonzalez Log when a plugin trigger is not executable #93
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows dokku to trigger plugin:update as root while keeping plugins owned by the Dokku user.
See https://github.blog/2022-04-12-git-security-vulnerability-announced/ for more details on this change (which was backported in to Git 2.25.1 for Ubuntu).
Closes dokku/dokku#5186