fix(torii-grpc): ensure correct u256 token id deser

[Larkooo]

Summary by CodeRabbit

• Bug Fixes
  • Improved token handling so that inputs not matching the expected format now safely revert to a default state, enhancing overall reliability and preventing unexpected errors.

[coderabbitai]

Walkthrough

Ohayo, sensei! This change updates the conversion logic from a Token to a proto::types::Token. The implementation now checks if the token_id is empty before processing. If it is empty, it assigns a default value of U256::ZERO converted to bytes. If not, it continues with the original conversion process. This modification enhances error handling for cases where the token_id might be empty.

Changes

File Path	Change Summary
crates/torii/grpc/src/server/mod.rs	Updated From<Token> for proto::types::Token implementation. Introduced a conditional check for empty token_id. If empty, assigns U256::ZERO; otherwise, proceeds with the original conversion process.

Sequence Diagram(s)

sequenceDiagram
    participant T as Token
    participant C as Conversion (From<Token> for proto::types::Token)
    participant D as DefaultHandler

    T->>C: Provide Token with token_id
    alt Token ID is empty
        C->>D: Assign U256::ZERO as token_id
        D-->>T: Return token with default token_id
    else Token ID is not empty
        C->>C: Trim "0x" prefix from token_id
        C->>C: Convert token_id from hex string to byte vector
        C-->>T: Return processed token structure
    end

Loading

Possibly related PRs

• feat(torii-grpc): erc tokens and balances #2698: The changes in the main PR are related to the new Token struct introduced in this PR, as both involve the handling and conversion of Token instances.
• feat(torii-grpc): subscribe to token updates (metadata etc.) #2990: This PR adds a new token_id field to the Token message, which relates to the handling of the token_id field in the main PR.
• fix(torii-grpc): handle case token id for erc20 #3041: Both the main PR and this one involve modifications to how token_id is handled, focusing on error handling and conditional checks.

Suggested reviewers

• glihm

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between fbe9503 and 38c69e7.

📒 Files selected for processing (1)

• crates/torii/grpc/src/server/mod.rs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• crates/torii/grpc/src/server/mod.rs

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.11%. Comparing base (09d52f4) to head (34a85b9).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/torii/grpc/src/server/mod.rs	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3111      +/-   ##
==========================================
+ Coverage   57.06%   57.11%   +0.05%     
==========================================
  Files         442      442              
  Lines       61233    61178      -55     
==========================================
  Hits        34943    34943              
+ Misses      26290    26235      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.