Skip to content

Conversation

@jellison
Copy link

@jellison jellison commented Mar 18, 2020

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit tests are included in the PR
  • For new widgets, an entry has been added to the .dojorc
  • Any widget variant uses theme.compose like this
  • WidgetProperties are exported

Description:

Pagination widget

image

Resolves #1123

@vercel
Copy link

vercel bot commented Apr 1, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/dojo/dojowidgets/plbwb7ggh
✅ Preview: https://dojowidgets-git-fork-jellison-paginationwidget.dojo1.now.sh

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #1156 into master will increase coverage by 0.07%.
The diff coverage is 92.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1156      +/-   ##
==========================================
+ Coverage   88.63%   88.71%   +0.07%     
==========================================
  Files          81       83       +2     
  Lines        3853     3924      +71     
  Branches      976      989      +13     
==========================================
+ Hits         3415     3481      +66     
- Misses        252      257       +5     
  Partials      186      186              
Impacted Files Coverage Δ
src/pagination/index.tsx 92.75% <92.75%> (ø)
src/pagination/Pagination.nls.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0520637...e23c223. Read the comment docs.

@jellison jellison changed the title WIP: Pagination widget Pagination widget Apr 1, 2020
@jellison
Copy link
Author

jellison commented Apr 1, 2020

Issue exists under certain controlled scenarios.

2020-04-01_14-23-44

@jellison
Copy link
Author

jellison commented Apr 2, 2020

Render issue has been resolved by dojo/framework#712

@jellison jellison merged commit 4f24d68 into dojo:master Apr 2, 2020
@jellison jellison deleted the pagination_widget branch April 2, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pagination widget

2 participants