-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MenuItem
, Menu
, SubMenu
, and MenuBar
widgets
#104
Commits on Apr 19, 2017
-
Matt Wistrand committed
Apr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for cb2941a - Browse repository at this point
Copy the full SHA cb2941aView commit details -
Add keypress and focusin events to the menu widget
Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 30225d1 - Browse repository at this point
Copy the full SHA 30225d1View commit details -
Fix animation when menu starts opened.
Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 78d111a - Browse repository at this point
Copy the full SHA 78d111aView commit details -
Matt Wistrand committed
Apr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for f2f55aa - Browse repository at this point
Copy the full SHA f2f55aaView commit details -
Add menu comments and
animate
function propertyMatt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 4c359b0 - Browse repository at this point
Copy the full SHA 4c359b0View commit details -
- Use `properties.hidden` directly instead of passing it around. - Disambiguate `isHidden` to `requestShow` in `_toggleDisplay`. - Create an export base classes from Menu and MenuItem. - Remove underscore prefix from protected class members. - Fix doc comments for Menu/MenuItem properties. - Fix MenuItem child type.
Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for dd359ee - Browse repository at this point
Copy the full SHA dd359eeView commit details -
- Remove the ability to specify `animate` as a function. - Remove `getAriaProperties` in favor of individual properties. - Simplify the MenuItem widget.
Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 2938530 - Browse repository at this point
Copy the full SHA 2938530View commit details -
Additional Menu/MenuItem updates
- Remove unused import - Remove menu/example.html - Fix example page - Use `KeyboardEvent#keyCode` where `key` is unavailable - Consolidate menu CSS into a single module - Ensure menu is scrolled to top when animating open
Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 97135c7 - Browse repository at this point
Copy the full SHA 97135c7View commit details -
Matt Wistrand committed
Apr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 487f07c - Browse repository at this point
Copy the full SHA 487f07cView commit details -
Move menu colors into common variables
Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for dd1bd20 - Browse repository at this point
Copy the full SHA dd1bd20View commit details -
- Use `onElementCreated` and `onElementUpdated` - Correct use of `KeyboardEvent#keyCode` - Privacy updates
Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 9745208 - Browse repository at this point
Copy the full SHA 9745208View commit details -
`MenuItem`: - Allow tag and vnode properties to be set. - Fix ARIA properties. - Allow different `role`s to be applied. `Menu`: - Update keyboard handling to more accurately match the WAI-ARIA spec. - Add handling for right/left arrows, space key. - Internalize active index management. - Add an `orientation` property.
Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 00a2c82 - Browse repository at this point
Copy the full SHA 00a2c82View commit details -
Fix: animate only when
hidden
changes.Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 21d8899 - Browse repository at this point
Copy the full SHA 21d8899View commit details -
- Rename event listener names for consistency with other widgets. - Change `container`/`nestedMenuContainer` CSS classes to `root`/`nestedMenuRoot`, respectively. - Use CSS variable for menu animation duration. - Simplify function property checks. - Only move focus from the label into the menu when navigating via the keyboard. - Add `hideOnActivate` options. - Always expand submenus when the designated "descend" key is pressed.
Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 56b962f - Browse repository at this point
Copy the full SHA 56b962fView commit details -
Add
aria-checked
property to checkbox/radio menu itemsMatt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 3f8cb65 - Browse repository at this point
Copy the full SHA 3f8cb65View commit details -
Matt Wistrand committed
Apr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for c149e2f - Browse repository at this point
Copy the full SHA c149e2fView commit details -
- general cleanup - remove tabIndex from menu container - reset active index on hide - move focus on click
Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 7317abf - Browse repository at this point
Copy the full SHA 7317abfView commit details -
- Prevent the default action when the down arrow key is pressed while the menu trigger is focused. - Add `parentOrientation` property to ensure that vertical submenus of horizontal menus are opened with down arrow key instead of the right arrow key.
Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 06b0706 - Browse repository at this point
Copy the full SHA 06b0706View commit details -
Matt Wistrand committed
Apr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 90dd3d5 - Browse repository at this point
Copy the full SHA 90dd3d5View commit details -
Separate menu and hideable menu.
Simplify the `Menu` widget to do nothing more than render a list of menu children and manage the keyboard/mouse event interactions with them. Create a separate `SubMenu` widget that renders a menu item that toggles the menu in-and-out of view.
Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 0ec6398 - Browse repository at this point
Copy the full SHA 0ec6398View commit details -
Implement dropdown functionality.
Update `SubMenu` with dropdown functionality and the beginnings of popup functionality.
Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 7947e12 - Browse repository at this point
Copy the full SHA 7947e12View commit details -
Matt Wistrand committed
Apr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 5676050 - Browse repository at this point
Copy the full SHA 5676050View commit details -
- Add guard to focusout handler to prevent destroyed widgets from being manually inactivated. - Change `animate` to `animation`. - Toggle menu with space key. - `MenuItem`s default to `a` tag. - Implement `hideOnBlur` property. - Respond to submenu key events only when active - Update privacy of MenuItem methods. - Stop propagation when an arrow key is pressed on a SubMenu trigger to prevent navigation within a parent menu. - Focus menu items within a rAF call in order to give any animations time to complete.
Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 84ee217 - Browse repository at this point
Copy the full SHA 84ee217View commit details -
Matt Wistrand committed
Apr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for d2f3a64 - Browse repository at this point
Copy the full SHA d2f3a64View commit details -
Ignore transpiled
super
calls in constructors.Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 1f75bba - Browse repository at this point
Copy the full SHA 1f75bbaView commit details -
Split
Menu
andSubMenu
styles.Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 0fc3d80 - Browse repository at this point
Copy the full SHA 0fc3d80View commit details -
Update the focus logic in `MenuItem` to account for browsers that require more than one task to mark as visible elements being animated from `visibility: hidden`. Also update Menu readme.
Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 6b13dd8 - Browse repository at this point
Copy the full SHA 6b13dd8View commit details -
Put a cap on how many frames `MenuItem` will wait before ceasing to wait for its DOM node to become hidden.
Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for ce92ceb - Browse repository at this point
Copy the full SHA ce92cebView commit details -
- Improve popup logic and add an example. - Activate menu items when the enter key is pressed. - Add a `menuId` property to `MenuItem` so that ancestor menus can ignore clicks within nested menus.
Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for cf2621b - Browse repository at this point
Copy the full SHA cf2621bView commit details -
Use
@dojo/core/lang.createHandle
in menu widgets.Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 567ecb2 - Browse repository at this point
Copy the full SHA 567ecb2View commit details -
Allow menu/trigger CSS in SubMenu to be overridden.
Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for afb9019 - Browse repository at this point
Copy the full SHA afb9019View commit details -
Replace the `fadeIn`/`fadeOut` keyframes with a simpler transition (h/t @smhigley).
Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for 203b884 - Browse repository at this point
Copy the full SHA 203b884View commit details -
- Use spaces for the TypeDoc comments. - Remove unneeded `nested` property. - Create common `Keys` and `observeViewport` utilities. - Allow slide pane trigger to be a DNode.
Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for a3ce238 - Browse repository at this point
Copy the full SHA a3ce238View commit details -
Remove
menuId
property fromMenuItem
.Replace the `menuId` property from `MenuItem` with a `onMouseDown` property, and update event-related properties to accept both the event and an optional `index`.
Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for ab0c84d - Browse repository at this point
Copy the full SHA ab0c84dView commit details -
- Fix util tests - Use updated `Keys` enum - Remove variables.css.d.ts
Matt Wistrand committedApr 19, 2017 Configuration menu - View commit details
-
Copy full SHA for dbf3e5c - Browse repository at this point
Copy the full SHA dbf3e5cView commit details
Commits on Apr 20, 2017
-
- Convert `Orientation` to an enum - Add custom element descriptors - Only create a default menu id when the property is missing
Matt Wistrand committedApr 20, 2017 Configuration menu - View commit details
-
Copy full SHA for b66fb22 - Browse repository at this point
Copy the full SHA b66fb22View commit details