Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

Add start position information for a drag event #718

Merged
merged 3 commits into from
Oct 11, 2017

Conversation

kitsonk
Copy link
Member

@kitsonk kitsonk commented Oct 11, 2017

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

This PR enhances the Drag meta provider by providing a start property on drag results. This start property is a matrix of positional information from the pointer event. It therefore makes it possible to determine where the pointer location is by taking one of the properties of the start property and adding the delta property.

This is useful in cases where a render function needs to instantiate something at a particular location of where the pointer event is occurring.

Resolves #715

@kitsonk kitsonk added the beta4 label Oct 11, 2017
@kitsonk kitsonk added this to the 2017.10 milestone Oct 11, 2017
@kitsonk kitsonk requested a review from tomdye October 11, 2017 11:15
@kitsonk
Copy link
Member Author

kitsonk commented Oct 11, 2017

I removed a redundant if block, the other uncovered else block should ideally have a test where there is a RAF before the up event which should cause the start to be populated.

Copy link
Member

@tomdye tomdye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should work fine for JLG's needs. Thanks for the quick turnaround.

@kitsonk kitsonk merged commit 4686d53 into dojo:master Oct 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants