WebAnimations Meta

[tomdye]

Type: feature

The following has been addressed in the PR:

• There is a related issue
• All code matches the style guide
• Unit or Functional tests are included in the PR

Description:
Adds a WebAnimations meta which allows programatic web animations to be applied to a VNode.

import WebAnimation from '@dojo/widget-core/meta/WebAnimation';

export default class AnimatedWidget extends WidgetBase {
    protected render() {
        const animate = {
            id: 'rootAnimation',
            effects: [
                { height: '10px' },
                { height: '100px' }
            ],
            controls: {
                play: true
            }
        };

        this.meta(WebAnimation).animate('root', animate);

        return v('div', {
            key: 'root'
        });
    }
}

Resolves #657

[agubler]

couple of very minor nits and questions

[agubler]

nit: we don't need ` here, just '

[agubler]

Can we not type these?

[agubler]

any reason we can't bind the controls in here rather than in the meta?

[tomdye]

we can but it's potentially an array of arrays so wanted to avoid the extra loops. Can do though if you feel it's better?

[agubler]

Do you think we should warn if animate is passed without a key, might be surprising if it doesn't work?

[tomdye]

@agubler ready for another review

[agubler]

Is this really any?

[tomdye]

the bind scope is any in widgetBase I believe? I guess it should probably be WidgetBaseConstructor ?

[agubler]

It wouldn't be the constructor, it would just be WidgetBase if it is able to be typed.

[tomdye]

ok

[agubler]

why super.afterRender()?

[tomdye]

Is this not how you call the super function?

[agubler]

package-lock.json conflict now

[tomdye]

@agubler all done, please re-review