This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Updates for TypeScript 2.5 #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agubler
reviewed
Aug 31, 2017
package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@dojo/core": "next", |
There was a problem hiding this comment.
Did you mean to add these as deps?
There was a problem hiding this comment.
DOH! no... it was the freaking lack of --no-save and then me thinking it was just overwriting what was already there...
There was a problem hiding this comment.
The next release of grunt-dojo2 should fix that 😄
matt-gadd
approved these changes
Sep 1, 2017
|
Missed this was approved. Going to land it, and then see what 2.6 does. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description:
This PR uses the RC for TypeScript 2.5. There are a couple minor changes where TypeScript has gotten a bit more strict on typing of some complex types.
References: dojo/meta#197