Cache the function wrapper, no need to recreate each render. #903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 51aa1c2:
|
Codecov Report
@@ Coverage Diff @@
## master #903 +/- ##
=======================================
Coverage 94.60% 94.61%
=======================================
Files 127 127
Lines 8141 8145 +4
Branches 1900 1901 +1
=======================================
+ Hits 7702 7706 +4
Misses 439 439
Continue to review full report at Codecov.
|
matt-gadd
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug/feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
There is no need to recreate the property function wrapper each render, in addition this is causing issues with the custom element wrapper because the functions will always be referentially different.