Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate for async setting of icache #865

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

agubler
Copy link
Member

@agubler agubler commented Nov 26, 2020

Type: feature

The following has been addressed in the PR:

Description:

In order to be able to react to a "pending" state of an icache value we need to call invalidate at the start of calling the async setter and then also on the resolution.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 26, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9b1012b:

Sandbox Source
dojo/dojo-codesandbox-template Configuration

@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #865 (9b1012b) into master (86011f5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #865   +/-   ##
=======================================
  Coverage   94.72%   94.73%           
=======================================
  Files         127      127           
  Lines        8095     8103    +8     
  Branches     1889     1891    +2     
=======================================
+ Hits         7668     7676    +8     
  Misses        427      427           
Impacted Files Coverage Δ
src/core/middleware/icache.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86011f5...9b1012b. Read the comment docs.

@agubler agubler merged commit 272a7ef into dojo:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants