Allow numbers in vdom #781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 43bc3fd:
|
rorticus
approved these changes
May 22, 2020
Contributor
rorticus
left a comment
rorticus
left a comment
There was a problem hiding this comment.
I think this looks good!
Codecov Report
@@ Coverage Diff @@
## master #781 +/- ##
==========================================
+ Coverage 97.48% 97.51% +0.03%
==========================================
Files 126 127 +1
Lines 7624 7725 +101
Branches 1759 1773 +14
==========================================
+ Hits 7432 7533 +101
Misses 192 192
Continue to review full report at Codecov.
|
matt-gadd
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
This would accept numbers as DNodes and render them. This seems straightforward so I'm not sure if there's any other reason we wouldn't want to allow this. I don't think we'd want to render booleans this way given the utility of the common
boolean && nodepattern.Resolves #761