Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/WidgetBase.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export class WidgetBase<P = WidgetProperties, C extends DNode = DNode> implement
* property specifically for typing when using tsx
*/
/* tslint:disable-next-line:variable-name */
public __properties__!: this['properties'] & WidgetProperties & { __children__?: DNode[] | DNode };
public __properties__!: this['properties'] & WidgetProperties & { __children__?: DNode | (DNode | DNode[])[] };

/**
* children array
Expand Down
2 changes: 1 addition & 1 deletion src/core/interfaces.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ export interface WidgetBaseInterface<P = WidgetProperties, C extends DNode = DNo
/**
* property used for typing with tsx
*/
__properties__: this['properties'] & { __children__?: DNode[] | DNode };
__properties__: this['properties'] & { __children__?: DNode | (DNode | DNode[])[] };
}

/**
Expand Down
22 changes: 21 additions & 1 deletion tests/core/unit/vdom.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2828,6 +2828,26 @@ jsdomDescribe('vdom', () => {
assert.strictEqual(root.innerHTML, 'hello');
});

it('tsx supports a mixture of array and non array children', () => {
class App extends WidgetBase {
render() {
return <div>{this.children}</div>;
}
}
const domNode = document.createElement('div');
const r = renderer(() => (
<App>
{[<div>first</div>, <div>second</div>]}
{<div>third</div>}
</App>
));
r.mount({ domNode });
assert.strictEqual(
domNode.outerHTML,
'<div><div><div>first</div><div>second</div><div>third</div></div></div>'
);
});

describe('supports merging with a widget returned a the top level', () => {
it('Supports merging DNodes onto existing HTML', () => {
const iframe = document.createElement('iframe');
Expand Down Expand Up @@ -3194,7 +3214,7 @@ jsdomDescribe('vdom', () => {
});
});

describe('functional', () => {
describe('function based', () => {
it('children', () => {
const createWidget = create({ invalidator });

Expand Down