Skip to content

Inert middleware #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
agubler merged 5 commits into from
Jan 6, 2020
Merged

Inert middleware #623

agubler merged 5 commits into from
Jan 6, 2020

Conversation

@agubler
Copy link
Member

@agubler agubler commented Dec 30, 2019 •
edited
Loading

Type: feature

The following has been addressed in the PR:

Description:

An inert middleware that leverages the inert shim to provide an API for setting inert on a node or inverting the inert to all elements attached to the node's parent except the node associated with the passed key. This enables trapping focus for scenario such as a dialog in combination with using the special body tag.

inert.set('my-dialog', true, true);

<body>
    <div key="my-dialog">
        <input></input>
    </div>
    <button onclick={() => { inert.set('my-dialog', false, true)}}>Close</button>
</body>

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 30, 2019 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9b42cad:

Sandbox Source
zen-goldberg-njrbk Configuration

@agubler agubler merged commit a143802 into dojo:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matt-gadd matt-gadd matt-gadd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@agubler @matt-gadd