Fix state in focus middleware #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gadd
approved these changes
Nov 5, 2019
matt-gadd
approved these changes
Nov 5, 2019
matt-gadd
approved these changes
Nov 5, 2019
agubler
force-pushed
the
fix-state-in-focus-middleware
branch
from
b13a953 to
8fcbbae
Compare
agubler
added a commit
to agubler/framework
that referenced
this pull request
Nov 5, 2019
* failing unit test * do not mix cache and icache
3 tasks
agubler
added a commit
that referenced
this pull request
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
The state in the focus middleware was incorrectly getting the current value from the cache, but setting it in the icache. This means that after the first focus call,
shouldFocuswould always befalse. This highlights just one of the issues with mixing icache and cache.This changes the logic to use icache for everything except the active element which is simply kept in the scope of the middlware.