Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding drag meta #545

Closed
wants to merge 1 commit into from
Closed

Adding drag meta #545

wants to merge 1 commit into from

Conversation

rorticus
Copy link
Contributor

Type: feature

The following has been addressed in the PR:

Description:

Converting Drag meta to drag middleware. This is basically a direct port of the drag meta. I tried a few ways to be clever but having a single copy of the event listeners, like this has, seemed like a better way to go.

Resolves #514

@agubler
Copy link
Member

agubler commented Oct 1, 2019

@rorticus Do you think we should be using a class in the functional middleware? Could this not be done all within the middleware?

@rorticus
Copy link
Contributor Author

rorticus commented Nov 6, 2019

@agubler I can poke around with that some more if you like. I originally went that direction but ran into issues because I wanted a single global event listener, and the middleware is created for each widget. I can take another shot at that though, basically moving a lot of the class stuff up to the module scope?

@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #545 into master will increase coverage by 0.02%.
The diff coverage is 98.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
+ Coverage   97.43%   97.45%   +0.02%     
==========================================
  Files         117      118       +1     
  Lines        6513     6614     +101     
  Branches     1479     1490      +11     
==========================================
+ Hits         6346     6446     +100     
- Misses        167      168       +1     
Impacted Files Coverage Δ
src/testing/mocks/middleware/icache.ts 92.85% <92.85%> (ø)
src/core/middleware/drag.ts 99.00% <99.00%> (ø)
src/core/WidgetBase.ts 100.00% <100.00%> (ø)
src/core/middleware/focus.ts 100.00% <100.00%> (ø)
src/core/middleware/icache.ts 100.00% <100.00%> (ø)
src/core/vdom.ts 98.92% <100.00%> (ø)
src/routing/ActiveLink.ts 100.00% <100.00%> (ø)
src/routing/Router.ts 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ac08c...e4a76d8. Read the comment docs.

@agubler agubler closed this Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag Middleware
2 participants