Skip to content

Support rendering nodes to the document body #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
agubler merged 3 commits into from
Jul 16, 2019
Merged

Support rendering nodes to the document body #448

agubler merged 3 commits into from
Jul 16, 2019

Conversation

@agubler
Copy link
Member

@agubler agubler commented Jul 16, 2019 •
edited
Loading

Type: feature

The following has been addressed in the PR:

Description:

Adds support for a special vnode tag, body that will render its children directly to the document.body.

import { create, tsx } from '@dojo/framework/core/vdom';

const factory = create();

const MyWidget = factory(function MyWidget() {
    return (
        <div>
            <body><div>Body Node</div></body>
            <div>Normal Node</div>
        </div>
    );
});

Resolves #447

tomdye
tomdye approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@tomdye tomdye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@agubler agubler merged commit 584898f into dojo:master Jul 16, 2019
@snyk-bot snyk-bot mentioned this pull request Nov 14, 2019
Open
@mwistrand mwistrand mentioned this pull request Dec 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomdye tomdye tomdye approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add ability to render DNodes to the document body

2 participants

@agubler @tomdye