Add start method to router #402
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Currently the
routeruses theQueuingEventedimplementation to queue events that happen before there are listeners attached.However at the moment the
registerRouterInjectorhelper, connects to thenavevent automatically which means that any listeners added after callingregisterRouterInjectorwill not receive the initialnavevents.This change introduces a
startmethod to the router and anautostartproperty to theRouterOptions. Theautostartproperty defaults totruewhich maintains the current behaviour, but when it is set tofalseit allows consumers to add listeners to the routing events before the router is "started". Once all the listeners have been configured, thestartmethod is required to be called.Resolves #386
Note: There are no other usages of
QueuingEventedthroughout framework and is not a recommended module to use externally so has been deleted from@dojo/framework/core.