Consolidate functionality across core into single module (vdom.ts) #360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
After merging
widget-corewithcore, this change colocates all the functionality required to build and use Dojo widgets into a single module,vdom.ts. The driver for this is not having a sane place to put the newcreatefactory for functional widgets and middleware. Also to reduce the minumum number of modules a user needs to import for Dojo.Before
After
Note: This will require some additional work for the
@dojo/cli-upgrade-appto seamlessly migrate user codebases to the new imports.