Skip to content

Conversation

@agubler
Copy link
Member

@agubler agubler commented Mar 7, 2019

Type: feature

The following has been addressed in the PR:

Description:

Changes to ensure that VNodes and WNodes created by users are not mutated by the rendering engine:

  • Generate map of nodes to the widget instance that initially rendered to use for resolving registry items and adding DOM nodes to the widget NodeHandler for metas
  • Remove bind from VNode and WNode and automatically bind Widget functions to the widget instance (excluding constructor and render)
  • Resolve registry items in vdom, storing the resolved registry items on the WNodeWrapper
  • Create text VNode and filter undefined, null, false and true items in vdom
  • Remove originalProperties from VNode and WNode, process deferred properties in vdom storing the deferred properties results on the VNodeWrapper.

Resolves #289

@agubler agubler added enhancement New feature or request breaking change Indicates the issue/pull request would result in a breaking change labels Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Indicates the issue/pull request would result in a breaking change enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure that the framework does not mutate VNodes and WNodes

2 participants