No longer throw by default on unregistered has() checks #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gadd
commented
Feb 27, 2019
| * @param trueClass The class to use if feature test returns `true` | ||
| * @param falseClass The class to use if the feature test returns `false` or is not defined | ||
| */ | ||
| export function hasClass(feature: string, trueClass: Function, falseClass: Function): ClassDecorator { |
Contributor
Author
There was a problem hiding this comment.
i have absolutely no idea why this module exists and we should remove it in 6.
agubler
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
No longer throw when performing has() checks on unregistered features by default. Throwing by default is quite annoying, especially as we now leverage a lot of
has()checks as part of the build tool where they are mostly progressive, so when using without the build tool (ie in a codesandbox) we'd have to write different code.An additional strict param to enable the old functionality has been added.