Skip to content

Conversation

@agubler
Copy link
Member

@agubler agubler commented Nov 7, 2018

Type: bug

The following has been addressed in the PR:

Description:

A few fixes for StateHistory history adapter:

  1. Add leading slash if missing to base path
  2. Default to window.__public_path__ if it exists
  3. Strip base on pushing the state

Copy link
Member

@tomdye tomdye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me

@agubler agubler merged commit 54d27bb into dojo:master Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants