Fixes: Routing and Link Fixes #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gadd
reviewed
Oct 25, 2018
| if (path[0] === '#') { | ||
| path = path.slice(1); | ||
| } | ||
| if (path[0] === '/') { |
Contributor
There was a problem hiding this comment.
this can be one if with the above right?
Member
Author
There was a problem hiding this comment.
The reason I did this was to guard against #/link which needs to be link
matt-gadd
approved these changes
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
A collection of fixes for the routing:
setPathwhen usingHashHistory#character when usingStateHistoryResolves #147
Resolves #146
Resolves #145