Skip to content

Use '&' delimiter for query params #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agubler merged 1 commit into from
Sep 20, 2018
Merged

Use '&' delimiter for query params #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/routing/Router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ export class Router extends QueuingEvented<{ nav: NavEvent; outlet: OutletEvent
}
}
if (queryParamString) {
queryParams = queryParamString.split('$').map((queryParam) => {
queryParams = queryParamString.split('&').map((queryParam) => {
return queryParam.replace('{', '').replace('}', '');
});
}
Expand Down
28 changes: 28 additions & 0 deletions tests/routing/unit/Router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,34 @@ describe('Router', () => {
assert.strictEqual(link, 'foo/foo/bar/bar/baz/baz');
});

it('Should generate link with multiple params and query params', () => {
const router = new Router(
[
{
path: 'foo/{foo}/{bar}?{baz}&{qux}',
outlet: 'foo',
defaultParams: {
foo: 'defaultFoo',
bar: 'defaultBar',
baz: 'defaultBaz',
qux: 'defaultQux'
}
}
],
{ HistoryManager }
);
assert.strictEqual(
router.link('foo', {
foo: 'foo',
bar: 'bar',
baz: 'baz',
qux: 'qux'
}),
'foo/foo/bar?baz=baz&qux=qux'
);
assert.strictEqual(router.link('foo'), 'foo/defaultFoo/defaultBar?baz=defaultBaz&qux=defaultQux');
});

it('Will not generate a link if params are not available', () => {
const router = new Router(routeWithChildrenAndMultipleParams, { HistoryManager });
const link = router.link('baz');
Expand Down