Skip to content

ActiveLink‘s isActive check should take into account queryParams #697

@xiaohulu

Description

@xiaohulu

Enhancement

Package Version: 6.0.5

Some url should append common query param pageid, for example

my/path1?pageid=1
my/path2?pageid=2

When outlet path contains queryParam ?{pageid}, ActiveLink's activeClasses not work.

Code

https://codesandbox.io/s/staging-violet-e3rib

Expected behavior:

If Outlet path contains queryParam my/path?{queryParam}, should set background color to red when Link is active.

Actual behavior:

not set activeClasses when Link is active.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: routingRoutingbugSomething isn't workinghelp wantedExtra attention is neededneeds back-portThe fix requires back porting to one or more previous major versions

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions