Throw error on existing theme file and Generate definition files#44
Open
KaneFreeman wants to merge 4 commits intodojo:masterfrom
Open
Throw error on existing theme file and Generate definition files#44KaneFreeman wants to merge 4 commits intodojo:masterfrom
KaneFreeman wants to merge 4 commits intodojo:masterfrom
Conversation
Throw an error when a theme file already exists. Do not create any css module files.
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 95.83% 96.03% +0.20%
==========================================
Files 7 7
Lines 96 101 +5
Branches 5 5
==========================================
+ Hits 92 97 +5
Misses 4 4
Continue to review full report at Codecov.
|
Generate definition files along with CSS modules.
KaneFreeman
changed the title
# Conflicts: # src/createThemeFile.ts # tests/unit/main.ts
Member
|
@KaneFreeman Is this change still valid, it sounds like it is? |
Member
|
ping @KaneFreeman |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Resolves #9
Resolves #8