Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix library to avoid clashes on the global scope #348

Merged

Conversation

agubler
Copy link
Member

@agubler agubler commented Nov 19, 2019

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR
  • schema.json has been updated appopriately

Description:

Prefix library name to avoid clashes on the global scope.

Resolves #347

@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #348 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   48.76%   48.76%           
=======================================
  Files          10       10           
  Lines         687      687           
  Branches      193      193           
=======================================
  Hits          335      335           
  Misses        352      352
Impacted Files Coverage Δ
src/base.config.ts 19.82% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc8f887...5ba6fe4. Read the comment docs.

@agubler agubler changed the title Prefix library to avoid classes on the global scope Prefix library to avoid clashes on the global scope Nov 19, 2019
@agubler agubler merged commit 4b8d7d6 into dojo:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: dojo global scope and lib name clash
2 participants