Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support globs in .dojorc bundle config for matching modules #260

Merged
merged 6 commits into from
Mar 22, 2019

Conversation

agubler
Copy link
Member

@agubler agubler commented Mar 21, 2019

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

Adds support for matching bundles based on a glob using minimatch.

Resolves #250

@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #260 into master will decrease coverage by 0.58%.
The diff coverage is 5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
- Coverage   52.46%   51.88%   -0.59%     
==========================================
  Files          10       10              
  Lines         629      638       +9     
  Branches      157      162       +5     
==========================================
+ Hits          330      331       +1     
- Misses        299      307       +8
Impacted Files Coverage Δ
src/base.config.ts 23.15% <5%> (-0.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 687a8ed...00ba08b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants