Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict css module checks #251

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Conversation

matt-gadd
Copy link
Contributor

@matt-gadd matt-gadd commented Mar 1, 2019

Type: feature

The following has been addressed in the PR:

  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:
This throws warnings in the build if we detect any selectors in m.css files that can potentially leak into other widgets. The 2 scenario's handled with this PR are any element/tag selectors and the universal selector.

Copy link
Member

@tomdye tomdye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gona cause a lot of hurt, but it's for the best!
Should probably raise for build-widget / build-theme etc too.
Nice 👍

@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #251 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
- Coverage   52.48%   52.46%   -0.02%     
==========================================
  Files          10       10              
  Lines         625      629       +4     
  Branches      157      157              
==========================================
+ Hits          328      330       +2     
- Misses        297      299       +2
Impacted Files Coverage Δ
src/base.config.ts 23.75% <50%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16237e5...348dbe3. Read the comment docs.

@matt-gadd matt-gadd reopened this Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants