Automatically add a borderWidth to the button if borderColor is defined #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @jeremygrenier |
dogo
added a commit
that referenced
this pull request
Mar 19, 2015
Automatically add a borderWidth to the button if borderColor is defined
|
ops, was pointing to feature/show-in-a-new-window branch eheheh. I'll merge on master too |
|
I improved your PR. Merged with master and feature/show-in-a-new-window branch |
dogo
pushed a commit
that referenced
this pull request
Mar 26, 2015
* feature/show-in-a-new-window: (24 commits) Rename macro UIColorFromRGB to UIColorFromHEX Remove whitespaces Code formatting Expose Show methods without UIViewController Simplify statement Fix background rotation with new window Revert modal support Support SCLAlert using UIViewController and using a new window Bump version Expose circleIconHeight Update docs Fix shouldDismissOnTapOutside not working #87 Bump version Fix issue #86 Improve pull request #85 Automatically add a borderWidth to the button if borderColor is defined Bump version Fix background rotation Remove modal support Use button width not alert window width Remove CGSize buttonSize Replace hardcode values Init and viewWillLayoutSubviews refactor Bump version ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the borderColor for the completeButtonFormatBlock is totally useless. Thanks. ;)