Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: surpress warnings for TestVC4C #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

nomaddo
Copy link
Collaborator

@nomaddo nomaddo commented Dec 18, 2018

Currently, TestVC4C --fastregression show the following mis-leading warning:

$ ./cmake-build-debug/test/TestVC4C --fast-regressions
Cannot enable unknown optimization: ast-regressions

This is because parsing function parseConfigurationParameter output some warnings even though in TestVC4C.

This pullreq add a argument to parseConfigurationParameter to control printing warnings.

@nomaddo nomaddo requested a review from doe300 December 18, 2018 13:52
@nomaddo
Copy link
Collaborator Author

nomaddo commented Dec 18, 2018

BTW: in the latest master branch, TestVC4C only show warnings and stack trace.
I cannot see the coverage.

Copy link
Owner

@doe300 doe300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, if this is the right way...
Now it does not complain for any misspelled optimization name anymore, which is also not great.

@@ -173,7 +173,7 @@ namespace vc4c
*
* @return whether the parameter was successfully parsed and applied to the configuration
*/
bool parseConfigurationParameter(Configuration& config, const std::string& arg);
bool parseConfigurationParameter(Configuration& config, bool, const std::string& arg);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter needs a name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants