-
Notifications
You must be signed in to change notification settings - Fork 9
Add .NET 9,.NET 10. Drop .NET 10. Upgrade to latest L3 specification draft. #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vanbukin
wants to merge
113
commits into
main
Choose a base branch
from
net10
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
113 commits
Select commit
Hold shift + click to select a range
a84eeeb
Upgrade TFM to .NET 8, 9 and 10
vanbukin 0262358
Migrate .sln to .slnx
vanbukin 48111ab
Make project builable on .NET 8,9,10 tfm.
vanbukin b2da6f6
Apply formatting and refactor code for improved consistency and clarity.
vanbukin 808cf28
Remove redundant Microsoft.Extensions.* package references across pro…
vanbukin 9389038
Refactor `_credentials` field to use `ICollection` for improved flexi…
vanbukin 23c4c0e
Refactor WebAuthn options initialization by introducing `FakeWebAuthn…
vanbukin cf787cb
Refactor Fido metadata background service and CborNegativeInteger cla…
vanbukin 0bbbd61
Update README.md to replace dated WebAuthn Level 3 links with stable …
vanbukin 5e3d298
Update README.md to replace WebAuthn specification links with stable …
vanbukin a619e8b
Remove unused attestation-related properties and update WebAuthn spec…
vanbukin 9a6147a
Update WebAuthn specification links with stable references in `Authen…
vanbukin 231802c
Update `AttestationConveyancePreference` documentation to use stable …
vanbukin f13809a
Update `AttestationStatementFormat` documentation to use stable WebAu…
vanbukin ce9c88a
Update `AuthenticatorAttachment` documentation to use stable WebAuthn…
vanbukin 4ffccb5
Update `AuthenticatorTransport` documentation to use stable WebAuthn …
vanbukin 3c4172b
Update `PublicKeyCredentialHints` documentation to use stable WebAuth…
vanbukin 5f3dc80
Update `PublicKeyCredentialType` documentation to use stable WebAuthn…
vanbukin 7b7efb0
Update `ResidentKeyRequirement` documentation to use stable WebAuthn …
vanbukin 4cf9c53
Update `UserVerificationRequirement` documentation to use stable WebA…
vanbukin 6ba071e
Remove attestation-related properties and unused references across au…
vanbukin ef543b5
Update `AuthenticationResponse` documentation to use stable WebAuthn …
vanbukin a071239
Update `AuthenticationResponse` documentation to use stable WebAuthn …
vanbukin 63784d5
Update `RegistrationResponseJSON` documentation to use stable WebAuth…
vanbukin f52bbd3
Update `AuthenticatorAttestationResponseJSON` documentation to use st…
vanbukin a33c5b9
Update `AuthenticatorSelectionCriteriaJSON` documentation to use stab…
vanbukin 4780b42
Bump .NET SDK to 10.0.101
vanbukin 2539038
Update documentation to use stable WebAuthn specification links and i…
vanbukin 18d7887
Update `PublicKeyCredentialDescriptorJSON` documentation to use stabl…
vanbukin 96caddd
Refactor constructors in `PublicKeyCredentialDescriptorJSON` and enco…
vanbukin cde6609
Update `PublicKeyCredentialDescriptor` and `PublicKeyCredentialDescri…
vanbukin 1968691
Update `PublicKeyCredentialDescriptor` documentation to use stable We…
vanbukin e90f82a
Update `AuthenticatorAttestationResponse` and `AuthenticatorAttestati…
vanbukin b3b071e
Update `RegistrationResponse` documentation to use stable WebAuthn sp…
vanbukin 50dd0cb
Update `AuthenticatorSelectionCriteria` documentation to use stable W…
vanbukin 8471371
Update `PublicKeyCredentialCreationOptions` and `PublicKeyCredentialC…
vanbukin 36bebb9
Update `PublicKeyCredentialParameters` documentation to use stable We…
vanbukin bca6ee2
Update `PublicKeyCredentialRpEntity` documentation to use stable WebA…
vanbukin e504338
Update `PublicKeyCredentialUserEntity` documentation to use stable We…
vanbukin bd8fa4e
Update `X509ChainValidationOptions` to adjust chain validation polici…
vanbukin ba9f58d
Update package references and conditionally handle certificate loadin…
vanbukin ce04429
Update `AndroidKeyAttestationStatementOptions` documentation to use s…
vanbukin bda635d
Update `NoneAttestationOptions` documentation to use stable WebAuthn …
vanbukin 8ced445
Update `SelfAttestationOptions` documentation to use stable WebAuthn …
vanbukin a91b5f1
Update `AttestationStatementOptions` documentation to use stable WebA…
vanbukin ec94193
Update `SelfAttestationOptions` and `AttestationTypeOptions` document…
vanbukin e186fd7
Update `WebAuthnOptions` documentation to use stable WebAuthn specifi…
vanbukin b2d457a
Update `CredentialPublicKeyRecord` documentation to use stable WebAut…
vanbukin e6453c0
Update `UserCredentialRecord` documentation to use stable WebAuthn sp…
vanbukin 95fa49e
Update `CredentialRecord` documentation to use stable WebAuthn specif…
vanbukin ec65669
Update `CoseAlgorithm` documentation to use stable WebAuthn specifica…
vanbukin 96d70b5
Update `DefaultCoseKeyDeserializer` to use stable WebAuthn specificat…
vanbukin d9e55a6
Update `IAttestationObjectDecoder` and `AttestationObject` documentat…
vanbukin 5c6436b
Update `CredentialRecordUpdateResult` documentation to use stable Web…
vanbukin b9e2ba3
Update `CredentialBackupStateRecommendedAction` documentation to use …
vanbukin 3d9bab6
Update `InMemoryUserCredentialRecord` documentation to use stable Web…
vanbukin 46c8975
Update `MySqlPublicKeyCredentialDescriptor` and `MySqlUserCredentialR…
vanbukin 677b343
Rename `CredentialId` to `Id` in `MySqlPublicKeyCredentialDescriptor`…
vanbukin c0935a8
Rename `Id` to `CredentialId` in `MySqlPublicKeyCredentialDescriptor`…
vanbukin ab38f83
Update `PostgreSqlPublicKeyCredentialDescriptor` documentation to use…
vanbukin 304833d
Update `PostgreSqlUserCredentialRecord` documentation to use stable W…
vanbukin 491363c
Update `SqlServerPublicKeyCredentialDescriptor` documentation to use …
vanbukin 60e35f5
Update `SqlServerUserCredentialRecord` documentation to use stable We…
vanbukin f957a45
Remove unused attestation-related dependencies and replace WebAuthn s…
vanbukin 9cc2516
Update `AuthenticationCeremonyIncludeCredentials` documentation to us…
vanbukin c874a4a
Update `AuthenticationCeremonyPublicKeyCredentialDescriptor` document…
vanbukin e296363
Update `BeginAuthenticationCeremonyRequest` documentation to use stab…
vanbukin 80086b5
Update `CompleteAuthenticationCeremonyResult` documentation to use st…
vanbukin 2962d40
Update `IAuthenticationCeremonyService` documentation to use stable W…
vanbukin fe8ab07
Update `IAndroidKeyAttestationStatementDecoder` documentation to use …
vanbukin 90f61a7
Update `IAndroidSafetyNetAttestationStatementDecoder` documentation t…
vanbukin ee13585
Update `IAppleAnonymousAttestationStatementDecoder` documentation to …
vanbukin 4436a76
Update `IFidoU2FAttestationStatementDecoder` documentation to use sta…
vanbukin 1e4322f
Update `INoneAttestationStatementDecoder` documentation to use stable…
vanbukin 3ebcb9a
Update `IPackedAttestationStatementDecoder` documentation to use stab…
vanbukin 00ab9c9
Update `ITpmAttestationStatementDecoder` documentation to use stable …
vanbukin 4579a66
Update `DefaultAttestationStatementDecoder` documentation to use stab…
vanbukin d2ef1e6
Update `AndroidKeyAttestationStatement` documentation to use stable W…
vanbukin 0907965
Update `AndroidSafetyNetAttestationStatement` documentation to use st…
vanbukin 50a16f2
Update `AppleAnonymousAttestationStatement` documentation to use stab…
vanbukin d80c548
Update `FidoU2FAttestationStatement` documentation to use stable WebA…
vanbukin d681161
Update `NoneAttestationStatement` documentation to use stable WebAuth…
vanbukin 0ac81e6
Update `PackedAttestationStatement` documentation to use stable WebAu…
vanbukin c42ef7f
Update `TpmAttestationStatement` documentation to use stable WebAuthn…
vanbukin b77c97e
Update `IAndroidKeyAttestationStatementVerifier` documentation to use…
vanbukin b2b106c
Update `IAndroidKeyAttestationStatementVerifier` and `IAndroidSafetyN…
vanbukin f6a5d5a
Update `IAndroidSafetyNetAttestationStatementVerifier` documentation …
vanbukin d0698c6
Update `IAppleAnonymousAttestationStatementVerifier` documentation to…
vanbukin 98e70dc
Update `IFidoU2FAttestationStatementVerifier` documentation to use st…
vanbukin 60fe386
Update `INoneAttestationStatementVerifier` documentation to use stabl…
vanbukin 11d66ee
Update `IPackedAttestationStatementVerifier` documentation to use sta…
vanbukin 6d10db1
Update `ITpmAttestationStatementVerifier` documentation to use stable…
vanbukin 24fc527
Update `AndroidKeyRoots` documentation to use stable WebAuthn specifi…
vanbukin ab8c122
Refactor `AndroidKey` root certificates: remove unused RSA key file, …
vanbukin 83fcfce
Update `DefaultAndroidKeyAttestationStatementVerifier` documentation …
vanbukin 853dbd9
Update `DefaultAndroidKeyAttestationStatementVerifier` to use stable …
vanbukin 11d9e2f
Update `DefaultAndroidSafetyNetAttestationStatementVerifier` and `And…
vanbukin c29f33d
Update `AppleRoots` documentation to use stable WebAuthn specificatio…
vanbukin 097ec50
Update `DefaultAppleAnonymousAttestationStatementVerifier` documentat…
vanbukin cfaf31c
Update `FidoU2FAttestationTypeResult` documentation to use stable Web…
vanbukin 3ddd4c8
Update `AttestationType` documentation to use stable WebAuthn specifi…
vanbukin e1f0930
Update `DefaultFidoU2FAttestationStatementVerifier` documentation to …
vanbukin 799e03c
Update `DefaultNoneAttestationStatementVerifier` documentation to use…
vanbukin ebccfd6
Update `FidoPackedAttestationTypeResult` documentation to use stable …
vanbukin 1c232d2
Update `DefaultPackedAttestationStatementVerifier` documentation to u…
vanbukin 5feeb30
Update `TpmRoots` documentation to use stable WebAuthn specification …
vanbukin 00644d5
Update `DefaultTpmAttestationStatementVerifier` and `DefaultTpmCertIn…
vanbukin 29271de
Update `DefaultAttestationStatementVerifier` documentation to use sta…
vanbukin 87a194f
Update `DefaultAuthenticatorDataDecoder` and `DefaultAttestationTrust…
vanbukin 0bee863
Update `AuthenticatorDataFlags` documentation to use stable WebAuthn …
vanbukin 1a11aad
Update documentation to use stable WebAuthn specification links in `N…
vanbukin 9aadcbd
Update `AttestedCredentialData` documentation to use stable WebAuthn …
vanbukin 833b9f3
Remove `TokenBinding` model, related enums, and unused references whi…
vanbukin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| <Solution> | ||
| <Folder Name="/root/"> | ||
| <File Path=".editorconfig"/> | ||
| <File Path=".gitattributes"/> | ||
| <File Path=".gitignore"/> | ||
| <File Path="Directory.Build.props"/> | ||
| <File Path="global.json"/> | ||
| <File Path="NOTICE.md"/> | ||
| <File Path="README.md"/> | ||
| </Folder> | ||
| <Folder Name="/root/.config/"> | ||
| <File Path=".config/dotnet-tools.json"/> | ||
| </Folder> | ||
| <Folder Name="/root/.github/"/> | ||
| <Folder Name="/root/.github/workflows/"> | ||
| <File Path=".github/workflows/CI.yml"/> | ||
| <File Path=".github/workflows/Release.yml"/> | ||
| </Folder> | ||
| <Folder Name="/root/demo/"> | ||
| <Project Path="demo/WebAuthn.Net.Demo.FidoConformance/WebAuthn.Net.Demo.FidoConformance.csproj"/> | ||
| <Project Path="demo/WebAuthn.Net.Demo.Mvc/WebAuthn.Net.Demo.Mvc.csproj"/> | ||
| </Folder> | ||
| <Folder Name="/root/src/"> | ||
| <Project Path="src/WebAuthn.Net.OpenTelemetry/WebAuthn.Net.OpenTelemetry.csproj"/> | ||
| <Project Path="src/WebAuthn.Net.Storage.InMemory/WebAuthn.Net.Storage.InMemory.csproj"/> | ||
| <Project Path="src/WebAuthn.Net.Storage.MySql/WebAuthn.Net.Storage.MySql.csproj"/> | ||
| <Project Path="src/WebAuthn.Net.Storage.PostgreSql/WebAuthn.Net.Storage.PostgreSql.csproj"/> | ||
| <Project Path="src/WebAuthn.Net.Storage.SqlServer/WebAuthn.Net.Storage.SqlServer.csproj"/> | ||
| <Project Path="src/WebAuthn.Net/WebAuthn.Net.csproj"/> | ||
| </Folder> | ||
| <Folder Name="/root/tests/"> | ||
| <Project Path="tests/WebAuthn.Net.Tests.Unit/WebAuthn.Net.Tests.Unit.csproj"/> | ||
| </Folder> | ||
| </Solution> |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / CodeQL
Log entries created from user input High
Copilot Autofix
AI about 1 month ago
The best way to fix this issue is to sanitize any user-controlled values before logging them. Specifically, the HTTP method (
context.Request.Method), path and query (context.Request.GetEncodedPathAndQuery()), and body (intendedJson) should be stripped of any new line or carriage return characters that could lead to log spoofing. For plain text logs, usingstring.Replace("\r", "")andstring.Replace("\n", "")will remove line breaks. The changes should be made in the middleware, prior to logging (i.e., inInvokeAsync). Only these arguments need to be sanitized before being passed to the logger.Thus, update the arguments on line 41 as follows:
context.Request.Methodcontext.Request.GetEncodedPathAndQuery()intendedJsonNo new imports are needed; use
string.Replacemethods.