feat(docz): allow for custom properties in useMenus hook #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakannimer
reviewed
Nov 11, 2019
core/docz/src/hooks/useMenus.ts
Outdated
|
|
||
| const entriesOfMenu = (menu: string, entries: Entry[]) => | ||
| entries.filter(fromMenu(menu)).map(entryAsMenu) | ||
| entries.filter(fromMenu(menu)).map(e => e as any) as MenuItem[] |
There was a problem hiding this comment.
Could we remove the map since we're passing to it an identity function ?
|
Hey @NicolaiF Thanks for the PR, looks great ! The tests will make sure to test the code against the examples so you shouldn't need to 👍 I added one small comment, that applies to both uses of Let me know what you think before we merge and publish. |
in useMenus hook
|
Needed to update the types a couple of places to make it work without map, but it looks like everything works fine now! |
|
Awesome ! Thanks :) |
rakannimer
changed the title
|
Fixes #1238 (for future reference) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the feature of accessing custom properties from mdx-files in the useMenus hook.
As a side-effect of this, other preexisting fields such as slug and headings, are also included in the hook. This could potentially be improved by filtering these out, and only allowing for the original properties found in useMenus previously.
Pre-merge checklist