chore: cleaned up linting rules

.github/workflows/checks.yaml

@@ -47,7 +47,7 @@ jobs:
       - run: ./script/bootstrap
       - run: ./script/test
 
-  goreleaser:
+  snapshot:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout

.golangci.yaml

@@ -0,0 +1,18 @@
+linters:
+  presets:
+    - bugs
+    - comment
+    - complexity
+    - error
+    - format
+    - import
+    - module
+    - style
+    - test
+    - unused
+  disable:
+    - golint
+    - interfacer
+    - scopelint
+    - exhaustivestruct
+    - maligned

functions.go

@@ -10,7 +10,6 @@ import (
 	textTemplate "text/template"
 
 	sprig "github.com/Masterminds/sprig/v3"
-
 	shellquote "github.com/kballard/go-shellquote"
 )
 
@@ -34,7 +33,7 @@ func buildFuncMap(jsonDataFile string) FuncMap {
 }
 
 func dataFunc(jsonDataFileName string) func() map[string]interface{} {
-	var v map[string]interface{}
+	var dataFunctionMap map[string]interface{}
 
 	if jsonDataFileName != "" {
 		file := safeOpen(jsonDataFileName)
@@ -45,12 +44,12 @@ func dataFunc(jsonDataFileName string) func() map[string]interface{} {
 		}()
 
 		dec := json.NewDecoder(file)
-		if err := dec.Decode(&v); err != nil {
-			log.Fatalf("Unable to parse %s: %s", jsonDataFileName, err)
+		if err := dec.Decode(&dataFunctionMap); err != nil {
+			log.Printf("Unable to parse %s: %s", jsonDataFileName, err)
 		}
 	}
 
-	return func() map[string]interface{} { return v }
+	return func() map[string]interface{} { return dataFunctionMap }
 }
 
 func doTextTemplate(file string, funcMap FuncMap, emitter io.Writer) {

main.go

@@ -7,6 +7,7 @@ import (
 	kingpin "gopkg.in/alecthomas/kingpin.v2"
 )
 
+// nolint: gochecknoglobals
 var (
 	version = "dev"
 	commit  = "none"

utils.go

@@ -10,5 +10,6 @@ func safeOpen(path string) *os.File {
 	if err != nil {
 		log.Fatalf("Unable to open %s: %s", path, err)
 	}
+
 	return file
 }