Doc generation failed on extends

[djey47]

Following issue #418, I'm unable to perform doc generation for one of my JS classes

Here are source contents: https://gist.github.com/djey47/c8c6291f249e0e80d21689ea799df946

When running command (using latest 4.0.0.-beta.18):
documentation build --github -f html -o doc-html/ src/**

parsing fails:
[...]/node_modules/globals-docs/index.js:48 var d = lowerCased[env[i]][name.toLowerCase()]; ^ TypeError: Cannot read property 'toLowerCase' of undefined at Object.module.exports.getDoc /[...]/node_modules/globals-docs/index.js:48:40) at Array.<anonymous> (/[...]/node_modules/documentation/lib/output/util/linker_stack.js:47:26) at firstPass (/[...]/node_modules/documentation/lib/output/util/linker_stack.js:28:24) at LinkerStack.link (/[...]/node_modules/documentation/lib/output/util/linker_stack.js:103:10) at formatters.autolink (/[...]/node_modules/documentation/lib/output/util/formatters.js:65:16) at eval (lodash.templateSources[1]:35:11) at Array.map (native) at eval (lodash.templateSources[1]:34:28) at eval (lodash.templateSources[3]:84:11) at Array.forEach (native) error Command failed with exit code 1.

Note that a workaround exists when using @extends tag in class documentation.

[tmcw]

Unfortunately I can't replicate this issue. With v4.0.0-beta.18, this does not fail. In the old issue, you wrote that you were using beta.16 - is this happening on beta.16 or beta.18? It should be fixed in beta.18.

@tmcw I'm running into this issue on v4.0.0-beta.18, sadly:

$ documentation serve src/** --output docs/code/ --format html --watch
/Users/user/git/project/node_modules/globals-docs/index.js:48
        var d = lowerCased[env[i]][name.toLowerCase()];
                                       ^

TypeError: Cannot read property 'toLowerCase' of undefined
    at Object.module.exports.getDoc (/Users/user/git/project/node_modules/globals-docs/index.js:48:40)
    at Array.<anonymous> (/Users/user/git/project/node_modules/documentation/lib/output/util/linker_stack.js:47:26)
    at firstPass (/Users/user/git/project/node_modules/documentation/lib/output/util/linker_stack.js:28:24)
    at LinkerStack.link (/Users/user/git/project/node_modules/documentation/lib/output/util/linker_stack.js:103:10)
    at formatters.autolink (/Users/user/git/project/node_modules/documentation/lib/output/util/formatters.js:65:16)
    at eval (lodash.templateSources[9]:35:11)
    at Array.map (native)
    at eval (lodash.templateSources[9]:34:28)
    at eval (lodash.templateSources[11]:84:11)
    at Array.forEach (native)

The workaround of adding @extends tags to all extending classes worked, at least.

[djey47]

Hi,

sorry for late reply. Just installed v4.0.0-beta.18 and issue still persists with source code:
https://gist.github.com/djey47/c8c6291f249e0e80d21689ea799df946

Still using @extends workaround.

Thanks.

Edit:
Sorry for this, issue with module versions would always pick up an older version (beta9).
Now targetting ^4.0.0-beta.18 in package.json gets right module from yarn repository.

So I can't reproduce the issue, generated doc is the right one..
Thanks.

[tmcw]

Great, closing as fixed then. Feel free to open a new issue if this issue is found in anything beta.18 or newer.