Conversation
|
🤔 I have 2 problems, both with tools not outputting XML. For Psalm, it seems to work on this other PR: greg0ire/persistence#1 . I don't understand why: the version of Psalm is the exact same, and |
|
Removing the psalm phpunit plugin seems to fix the issue |
greg0ire
force-pushed
the
normalize-ci
branch
2 times, most recently
from
c2ec0e9 to
8775afb
Compare
| uses: "shivammathur/setup-php@v2" | ||
| with: | ||
| coverage: "pcov" | ||
| coverage: "none" |
There was a problem hiding this comment.
does this mean that we do not have a coverage metric for this library?
|
Not merging right now, I have a lot of similar PRs to other repositories, and we are discussing more inconsistencies, I will push more changes. See doctrine/persistence#105 and doctrine/orm#8116 if you want to give some input. |
This is part of a normalization effort accross projects.
| name: "Unit tests" | ||
|
|
||
| runs-on: "ubuntu-18.04" | ||
| runs-on: "ubuntu-latest" |
There was a problem hiding this comment.
i find this very risky, but maybe since stuff runs inside docker, does not matter that much
There was a problem hiding this comment.
Woops I noticed this comment after merging 😅
Yeah I find it risky too, but a little (deps are fixed). cc @bendavies @localheinz in case you have an opinion to share on this.
2 participants
No description provided.