Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

Update to PHP 8#39

Merged
SenseException merged 10 commits intodoctrine:2.0.xfrom
SenseException:php-8
Jan 6, 2023
Merged

Update to PHP 8#39
SenseException merged 10 commits intodoctrine:2.0.xfrom
SenseException:php-8

Conversation

@SenseException
Copy link
Member

@SenseException SenseException commented Dec 27, 2022

This PR replaces #28 because of the need for using a newer Persistence version

@SenseException SenseException mentioned this pull request Dec 27, 2022
Closed
@SenseException SenseException force-pushed the php-8 branch 2 times, most recently from e1614c7 to afe310c Compare December 31, 2022 21:57
@SenseException @greg0ire
Fix coding styles and analysis errors
a943fe9 
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
@SenseException
Copy link
Member Author

SenseException commented Jan 2, 2023 •
edited
Loading

Persistence 2.* has at least one missing class-string type that causes some compatibility headache. I'll update to Persistence 3.* and proceed with the update steps. The few composer dependants out there don't look like that they're still maintained.

@SenseException
Copy link
Member Author

SenseException commented Jan 2, 2023

Static analysis errors have risen from 6 to 30 errors. The other workflows are green. I guess I'm closer to a PR.

@SenseException
Rise phpstan level to 8
eb6b16a
@SenseException
Fix phpstan level 8 errors
ad0b86e
@SenseException
Fix type related coding standards
1d21359
@SenseException
Ignore phpstan errors of inconsistent types
2c24668 
Some types between SkeletonMapper and Persistence aren't the same and need to be reviewed and adapted in SkeletonMapper
@SenseException
Copy link
Member Author

SenseException commented Jan 5, 2023

@greg0ire or someone else: Could you please take a look at the ignoreErrors of phpstan.neon.dist? I'm not sure if these can be fixed without changing the whole skeleton-mapper because of differences between skeleton-mapper and Persistence.

@greg0ire
Copy link
Member

greg0ire commented Jan 5, 2023

Took a look, and it looks quite complicated. I think we should merge as is?

@SenseException SenseException marked this pull request as ready for review January 5, 2023 23:03
@SenseException
Copy link
Member Author

SenseException commented Jan 5, 2023

I'll create a new Branch for a major release.

@SenseException SenseException changed the base branch from 1.0.x to 2.0.x January 5, 2023 23:10
@SenseException
Copy link
Member Author

SenseException commented Jan 5, 2023

Done.

The majority of this PR after the dependency updates are PHPStan fixes + fixes of ignoreErrors and Coding Standard adaptations and fixes of previously excluded rules.

@SenseException SenseException merged commit fe3821a into doctrine:2.0.x Jan 6, 2023
@SenseException SenseException deleted the php-8 branch January 6, 2023 22:00
@SenseException
Copy link
Member Author

SenseException commented Jan 6, 2023

Thanks for the patience until this got finished. 💮

@greg0ire
Copy link
Member

greg0ire commented Jan 6, 2023

Thanks for doing this :)

@SenseException SenseException mentioned this pull request Jan 12, 2023
Merged
@derrabus derrabus added this to the 2.0.0 milestone Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@greg0ire greg0ire greg0ire approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@SenseException @greg0ire @derrabus