Skip to content
This repository was archived by the owner on Aug 14, 2024. It is now read-only.

Return iterable instead of array for findAll and findBy methods#24

Open
l-vo wants to merge 1 commit intodoctrine:1.1.xfrom
l-vo:find_returns_to_iterable
Open

Return iterable instead of array for findAll and findBy methods#24
l-vo wants to merge 1 commit intodoctrine:1.1.xfrom
l-vo:find_returns_to_iterable

Conversation

@l-vo
Copy link

@l-vo l-vo commented Feb 4, 2019

What about using iterable type instead of array ? It will allow to return generators or custom result set implementations

@l-vo l-vo force-pushed the find_returns_to_iterable branch 3 times, most recently from 412096f to e58bc04 Compare February 5, 2019 12:48
@l-vo l-vo force-pushed the find_returns_to_iterable branch from e58bc04 to 07c0375 Compare February 5, 2019 13:11
@jwage
Copy link
Member

jwage commented Apr 15, 2019

I think we will have to wait for doctrine/persistence 2.0 to do this since the Doctrine\SkeletonMapper\ObjectRepository\ObjectRepositoryInterface class implements Doctrine\Common\Persistence\ObjectRepository which returns an array.

@jwage jwage added this to the 2.0.0 milestone Apr 15, 2019
Base automatically changed from master to 1.1.x January 20, 2021 22:11
@derrabus derrabus removed this from the 2.0.0 milestone Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants