Deprecate static reflection #47
Conversation
It has become a burden to maintain, for no benefit since we cannot find usages for it in Doctrine itself. The plan is to create a new major version without this types, so that php 8 compatibility is achieved. After this, the package will consist in only 2 classes that should probably moved elsewhere.
|
|
||
| print_r($staticReflectionProperty->getUseStatements()); | ||
| The main functionality of this package has been deprecated, you should | ||
| not use it. |
There was a problem hiding this comment.
Tell me what you think about this: does Doctrine usually document deprecated functionality? IMO it's best not to encourage people to build more on it.
There was a problem hiding this comment.
Wording is strange. So are we deprecating the package, or not? If we are, wording should say so. If we aren't, why is this saying to not use the package if there is still some use?
There was a problem hiding this comment.
Yeah… if the main functionality of the package is deprecated, then what should it be used for and what's its new main functionality? Deprecating the whole thing and moving the relevant pieces elsewhere might be a more proper decision.
|
#24 added one TypedNoDefaultReflectionProperty of the 2 classes for the ORM, and is referenced in Persistence, maybe it should be moved to that lib? |
|
|
|
I agree |
|
ODM started using the package recently with doctrine/mongodb-odm#2188 |
|
@malarzm do you remember why the dependency was added? Asking because I can't find a reference to the |
|
@greg0ire the dependency was added to ensure we get latest |
|
I made some progress regarding the move at doctrine/persistence#122 , but I'm not quite there yet, help is welcome. |
It has become a burden to maintain, for no benefit since we cannot find
usages for it in Doctrine itself. The plan is to create a new major
version without this types, so that php 8 compatibility is achieved.
After this, the package will consist in only 2 classes that should
probably moved elsewhere.