Conversation
|
@beberlei I understand the changes, looks good! |
beberlei
force-pushed
the
add_typed_no_default_reflection_property_class_usage
branch
from
26533b2 to
1005a73
Compare
Member
Author
|
@sspat its going into 1.3 |
alcaeus
requested changes
Jan 16, 2020
| "doctrine/collections": "^1.0", | ||
| "doctrine/event-manager": "^1.0", | ||
| "doctrine/reflection": "^1.0" | ||
| "doctrine/reflection": "^1.1" |
Member
There was a problem hiding this comment.
Noting that this is required for a fix. Since this transitive dependency fixes the issue for ORM, we've decided to bump this in a patch release.
greg0ire
force-pushed
the
add_typed_no_default_reflection_property_class_usage
branch
from
7c8edd1 to
f584465
Compare
greg0ire
approved these changes
Jan 16, 2020
Member
|
I got rid of the merge commit and squashed the "address Andreas review" commit into the first |
beberlei
deleted the
add_typed_no_default_reflection_property_class_usage
branch
stof
reviewed
Jan 17, 2020
|
|
||
| public function __construct() | ||
| { | ||
| $this->supportsTypedPropertiesWorkaround = version_compare((string) phpversion(), '7.4.0') >= 0; |
Member
There was a problem hiding this comment.
I suggest replacing this property with an inline \PHP_VERSION_ID > 70400 check, which will be resolved at compile time by OPCache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #90
This adds a check for PHP 7.4 so that we don't incur the overhead of
getDefaultPropertiesevery time.It also changes the order of the reflection property creations, because RuntimePublicReflectionProperty already works with typed no default properties, and its the more specialized version that is necessary to be used to don't break lazy loading on typed properties.
@sspat Can you check?
Fixes #89