Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove deprecations about ns move #87

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Jan 8, 2020

We want to give ourselves time to address them in the other packages we
own and that consume this library.
Not doing so generates a lot of support from people asking how they can
fix the deprecations in their application, which they cannot. This
commit should be reverted in a following release, when at least all of
our packages have made the move.

@greg0ire
Copy link
Member Author

greg0ire commented Jan 8, 2020

To be merged if people in https://github.com/orgs/doctrine/teams/doctrinecore/discussions/11 agree to do so.

We want to give ourselves time to address them in the other packages we
own and that consume this library.
Not doing so generates a lot of support from people asking how they can
fix the deprecations in their application, which they cannot. This
commit should be reverted in a following release, when at least all of
our packages have made the move.
@greg0ire greg0ire force-pushed the temporarily-remove-deprecations branch from 91d88fe to 132709c Compare January 8, 2020 07:28
Copy link
Member

@beberlei beberlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea is to re-release the deprecations with version 1.4.0 in a branch that is entirely compatible with 1.3.x, so everyone can stick with 1.3 until doctrine/orm or doctrine/mongo-odm raises the requirement itself to persistence 1.4

@greg0ire greg0ire merged commit ff7e08b into doctrine:1.3.x Jan 9, 2020
@greg0ire greg0ire deleted the temporarily-remove-deprecations branch January 9, 2020 19:49
@greg0ire greg0ire added this to the 1.3.4 milestone Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants