Merged
Conversation
greg0ire
commented
Dec 12, 2019
greg0ire
force-pushed
the
load-classes-in-type-declarations
branch
2 times, most recently
from
f3c0f72 to
7a78c1b
Compare
alcaeus
approved these changes
Dec 13, 2019
Types extending these but having the old type declarations might not be considered compatible unless we autoload the type declarations. Fixes doctrine#78
alcaeus
force-pushed
the
load-classes-in-type-declarations
branch
from
7a78c1b to
f680c94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types extending these but having the old type declarations might not be
considered compatible unless we autoload the type declarations.
Fixes #78
How can I test this?
composer config repositories.greg0ire vcs https://github.com/greg0ire/doctrine-persistence composer require doctrine/persistence "dev-load-classes-in-type-declarations as 1.3.0"